Bug 53382 - Remove reference to ${CMAKE_SOURCE_DIR}/Source in CMake files
Summary: Remove reference to ${CMAKE_SOURCE_DIR}/Source in CMake files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Other
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-29 14:39 PST by Daniel Bates
Modified: 2011-01-29 15:14 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.31 KB, patch)
2011-01-29 14:55 PST, Daniel Bates 		mjs: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2011-01-29 14:39:51 PST 
Following up on bug 53253 comment 5, we should remove references to ${CMAKE_SOURCE_DIR}/Source in CMake files since CMAKE_SOURCE_DIR is taken to be /Source as implied by the definitions of JAVASCRIPTCORE_DIR, WEBCORE_DIR, WEBKIT_DIR, and TOOLS_DIR in /Source/CMakeLists.txt.
Comment 1 Daniel Bates 2011-01-29 14:55:11 PST 
Created attachment 80578 [details]
Patch
Comment 2 Patrick R. Gansterer 2011-01-29 14:56:47 PST 
LGTM
Comment 3 Daniel Bates 2011-01-29 15:14:51 PST 
Committed r77073: <http://trac.webkit.org/changeset/77073>