WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
53382
Remove reference to ${CMAKE_SOURCE_DIR}/Source in CMake files
https://bugs.webkit.org/show_bug.cgi?id=53382
Summary
Remove reference to ${CMAKE_SOURCE_DIR}/Source in CMake files
Daniel Bates
Reported
2011-01-29 14:39:51 PST
Following up on
bug 53253 comment 5
, we should remove references to ${CMAKE_SOURCE_DIR}/Source in CMake files since CMAKE_SOURCE_DIR is taken to be /Source as implied by the definitions of JAVASCRIPTCORE_DIR, WEBCORE_DIR, WEBKIT_DIR, and TOOLS_DIR in /Source/CMakeLists.txt.
Attachments
Patch
(2.31 KB, patch)
2011-01-29 14:55 PST
,
Daniel Bates
mjs
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2011-01-29 14:55:11 PST
Created
attachment 80578
[details]
Patch
Patrick R. Gansterer
Comment 2
2011-01-29 14:56:47 PST
LGTM
Daniel Bates
Comment 3
2011-01-29 15:14:51 PST
Committed
r77073
: <
http://trac.webkit.org/changeset/77073
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug