Bug 52936 - nrwt: add a network wrapper object so we can mock out network fetches for the json_* routines and test them better
Summary: nrwt: add a network wrapper object so we can mock out network fetches for the...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-21 15:49 PST by Dirk Pranke
Modified: 2011-02-04 12:48 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-01-21 15:49:20 PST 
We should create a network wrapper object (like we have for the filesystem now) add pass that to objects that need to fetch things over the net, like the json_results* classes (and rebaseline-chromium-webkit-tests). That'll speed up unit testing and make it more reliable, as well as allow us to get better coverage of the code.
Comment 1 Eric Seidel (no email) 2011-01-21 15:51:25 PST 
I agree.  Bugzilla needs this for better mocking as well.  Currently we have BugzillaQueries which allows similar mocking at a slightly higher level.
Comment 2 Dirk Pranke 2011-01-24 15:52:36 PST 
see bug 53040, which adds the first attempt at a network wrapper.
Comment 3 Dirk Pranke 2011-02-04 12:48:09 PST 
I've added the wrapper in common/system/urlfetcher.py, and we have a separate bug for tracking the json work, so I'm closing this now.