Bug 52684 - Don't return void from void function String::split
Summary: Don't return void from void function String::split
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Benjamin (Ben) Kalman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-18 16:56 PST by Benjamin (Ben) Kalman
Modified: 2011-02-17 00:06 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.57 KB, patch)
2011-01-18 16:56 PST, Benjamin (Ben) Kalman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin (Ben) Kalman 2011-01-18 16:56:04 PST
Don't return void from void function String::split
Comment 1 Benjamin (Ben) Kalman 2011-01-18 16:56:51 PST
Created attachment 79357 [details]
Patch
Comment 2 WebKit Commit Bot 2011-01-19 06:27:47 PST
Comment on attachment 79357 [details]
Patch

Clearing flags on attachment: 79357

Committed r76121: <http://trac.webkit.org/changeset/76121>
Comment 3 WebKit Commit Bot 2011-01-19 06:27:52 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2011-01-19 07:02:17 PST
http://trac.webkit.org/changeset/76121 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
http/tests/xmlhttprequest/cross-origin-authorization.html