WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
52405
results archives from commit-queue are too large to upload
https://bugs.webkit.org/show_bug.cgi?id=52405
Summary
results archives from commit-queue are too large to upload
Eric Seidel (no email)
Reported
2011-01-13 15:44:33 PST
results archives from commit-queue are too large to upload
Attachments
Patch
(3.18 KB, patch)
2011-01-13 15:44 PST
,
Eric Seidel (no email)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2011-01-13 15:44:53 PST
Created
attachment 78869
[details]
Patch
Adam Barth
Comment 2
2011-01-13 15:50:20 PST
Comment on
attachment 78869
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=78869&action=review
> Tools/Scripts/webkitpy/common/system/filesystem_mock.py:121 > + def remove_tree(self, path, ignore_errors=False): > + self.files = [file for file in self.files if not file.startswith(path)]
You wrote a mock but no unit test!
Adam Barth
Comment 3
2011-01-13 15:50:50 PST
Comment on
attachment 78869
[details]
Patch Ok on no unit test. But I'm not going to give you a cookie.
WebKit Commit Bot
Comment 4
2011-01-13 17:52:14 PST
Comment on
attachment 78869
[details]
Patch Clearing flags on attachment: 78869 Committed
r75760
: <
http://trac.webkit.org/changeset/75760
>
WebKit Commit Bot
Comment 5
2011-01-13 17:52:20 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6
2011-01-13 18:23:33 PST
http://trac.webkit.org/changeset/75760
might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: http/tests/xmlhttprequest/cross-origin-authorization.html
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug