Bug 52405 - results archives from commit-queue are too large to upload
Summary: results archives from commit-queue are too large to upload
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-13 15:44 PST by Eric Seidel (no email)
Modified: 2011-01-13 18:23 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.18 KB, patch)
2011-01-13 15:44 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-01-13 15:44:33 PST 
results archives from commit-queue are too large to upload
Comment 1 Eric Seidel (no email) 2011-01-13 15:44:53 PST 
Created attachment 78869 [details]
Patch
Comment 2 Adam Barth 2011-01-13 15:50:20 PST 
Comment on attachment 78869 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78869&action=review

> Tools/Scripts/webkitpy/common/system/filesystem_mock.py:121
> +    def remove_tree(self, path, ignore_errors=False):
> +        self.files = [file for file in self.files if not file.startswith(path)]

You wrote a mock but no unit test!
Comment 3 Adam Barth 2011-01-13 15:50:50 PST 
Comment on attachment 78869 [details]
Patch

Ok on no unit test.  But I'm not going to give you a cookie.
Comment 4 WebKit Commit Bot 2011-01-13 17:52:14 PST 
Comment on attachment 78869 [details]
Patch

Clearing flags on attachment: 78869

Committed r75760: <http://trac.webkit.org/changeset/75760>
Comment 5 WebKit Commit Bot 2011-01-13 17:52:20 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2011-01-13 18:23:33 PST 
http://trac.webkit.org/changeset/75760 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
http/tests/xmlhttprequest/cross-origin-authorization.html