Bug 52396 - Relax the ESSL valid charset a little bit to include " ' `
Summary: Relax the ESSL valid charset a little bit to include " ' `
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Zhenyao Mo
URL:
Keywords:
Depends on:
Blocks: 52390
  Show dependency treegraph
 
Reported: 2011-01-13 14:15 PST by Zhenyao Mo
Modified: 2011-01-14 19:37 PST (History)
4 users (show)

See Also:


Attachments
Patch (4.51 KB, patch)
2011-01-13 14:28 PST, Zhenyao Mo
kbr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zhenyao Mo 2011-01-13 14:15:59 PST
As gman@google points out, something like 

#ERROR "..."

is legal.  Also, folks tend to use these three characters a lot in the comments, and there is no risk of crashing if we include them.
Comment 1 Zhenyao Mo 2011-01-13 14:28:33 PST
Created attachment 78855 [details]
Patch

Simple patch.  Please review.
Comment 2 Kenneth Russell 2011-01-13 14:32:32 PST
Comment on attachment 78855 [details]
Patch

Looks fine.
Comment 3 Zhenyao Mo 2011-01-13 14:35:07 PST
Committed r75735: <http://trac.webkit.org/changeset/75735>