Bug 52344 - Region improvements
Summary: Region improvements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-12 18:19 PST by Anders Carlsson
Modified: 2011-01-12 18:35 PST (History)
0 users

See Also:


Attachments
Patch (2.98 KB, patch)
2011-01-12 18:20 PST, Anders Carlsson
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-01-12 18:19:20 PST
Region improvements
Comment 1 Anders Carlsson 2011-01-12 18:20:12 PST
Created attachment 78766 [details]
Patch
Comment 2 mitz 2011-01-12 18:33:24 PST
Comment on attachment 78766 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78766&action=review

> WebKit2/Platform/Region.cpp:214
> +void Region::Shape::move(const IntSize& delta)

The English word offset is probably a better name than a greek letter. Would be nice to see this function renamed to “translate” too.
Comment 3 Anders Carlsson 2011-01-12 18:35:01 PST
Committed r75669: <http://trac.webkit.org/changeset/75669>