Bug 51762 - Remove unused JSBinding source files
Summary: Remove unused JSBinding source files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on: 51714
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-30 12:48 PST by Darin Adler
Modified: 2010-12-30 16:24 PST (History)
1 user (show)

See Also:


Attachments
Patch (7.00 KB, patch)
2010-12-30 12:50 PST, Darin Adler
ddkilzer: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2010-12-30 12:48:46 PST
Remove unused JSBinding source files
Comment 1 Darin Adler 2010-12-30 12:50:22 PST
Created attachment 77696 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2010-12-30 13:12:56 PST
Comment on attachment 77696 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77696&action=review

> WebCore/ChangeLog:9
> +        * bindings/js/specialization: Removed.

It's too bad JSBindingState.h and JSBindindState.cpp aren't listed here in the ChangeLog.  It's useful to know when the files were removed by searching for them by name.
Comment 3 WebKit Commit Bot 2010-12-30 13:14:49 PST
Comment on attachment 77696 [details]
Patch

Rejecting attachment 77696 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-attachment', '--no-update', '--non-interactive', 77696]" exit_code: 2
Last 500 characters of output:
bindings/js/JSBinding.h
rm 'WebCore/bindings/js/JSBinding.h'
patching file WebCore/bindings/js/JSBindingsAllInOne.cpp
patching file WebCore/bindings/js/specialization/JSBindingState.cpp
rm 'WebCore/bindings/js/specialization/JSBindingState.cpp'
patching file WebCore/bindings/js/specialization/JSBindingState.h
rm 'WebCore/bindings/js/specialization/JSBindingState.h'

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'David Kilzer', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/7281311
Comment 4 Darin Adler 2010-12-30 16:24:48 PST
Committed r74814: <http://trac.webkit.org/changeset/74814>