RESOLVED FIXED 51749
Web Inspector: [REGRESSION] Load timing is requested for all resources (not only for the main one). 
https://bugs.webkit.org/show_bug.cgi?id=51749
Summary Web Inspector: [REGRESSION] Load timing is requested for all resources (not o...
Pavel Feldman
Reported 2010-12-30 06:34:54 PST
This regressed when I was extracting ResourceManager (r70853).
Attachments
[PATCH] Proposed change. (1.79 KB, patch)
2010-12-30 06:41 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed change. (2.23 KB, patch)
2011-01-06 04:12 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2010-12-30 06:41:56 PST
Created attachment 77679 [details] [PATCH] Proposed change.
Tony Gentilcore
Comment 2 2011-01-05 10:19:40 PST
For web timing to work properly, we should set this for all frames (including sub frames, not just main frames). It would be nice to add a regression test, but I'm guessing there's no good way to do that because test shell doesn't populate resource timing. Everything else looks good to me.
Pavel Feldman
Comment 3 2011-01-06 04:12:48 PST
Created attachment 78109 [details] [PATCH] Proposed change.
Pavel Feldman
Comment 4 2011-01-06 04:15:37 PST
(In reply to comment #2) > For web timing to work properly, we should set this for all frames (including sub frames, not just main frames). It would be nice to add a regression test, but I'm guessing there's no good way to do that because test shell doesn't populate resource timing. > > Everything else looks good to me. Modified to report timing for subframes. Did not put the call into Timing for now, but moved it out from inspector.
Ilya Tikhonovsky
Comment 5 2011-01-06 06:28:32 PST
Comment on attachment 78109 [details] [PATCH] Proposed change. looks good to me
Tony Gentilcore
Comment 6 2011-01-06 10:57:44 PST
You might mention something in the ChangeLog about the motivation for moving to ResourceLoadNotifier. Although I'm still sad about the inability to test, this LGTM.
Yury Semikhatsky
Comment 7 2011-01-11 03:37:19 PST
Comment on attachment 78109 [details] [PATCH] Proposed change. Inspector change looks good to me, I lean on Tony's comment about reporting the timing for the subframes.
Pavel Feldman
Comment 8 2011-01-11 03:44:25 PST
Comment on attachment 78109 [details] [PATCH] Proposed change. Clearing flags on attachment: 78109 Committed r75485: <http://trac.webkit.org/changeset/75485>
Pavel Feldman
Comment 9 2011-01-11 03:44:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.