Bug 51726 - drawElements should raise INVALID_OPERATION if offset is not a multiple of the type size
Summary: drawElements should raise INVALID_OPERATION if offset is not a multiple of th...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Zhenyao Mo
Depends on:
Reported: 2010-12-29 14:59 PST by Zhenyao Mo
Modified: 2010-12-29 20:54 PST (History)
7 users (show)

See Also:

Patch (2.83 KB, patch)
2010-12-29 15:31 PST, Zhenyao Mo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zhenyao Mo 2010-12-29 14:59:30 PST
See WebGL spec section 6.3
Comment 1 Zhenyao Mo 2010-12-29 15:23:28 PST
After re-examine the code, it seems that this is already taken care of in WebGLRenderingContext::validateElementArraySize.

However, we don't have tests covering this behavior.  I'll add test cases.
Comment 2 Zhenyao Mo 2010-12-29 15:31:20 PST
Created attachment 77648 [details]
Comment 3 Eric Seidel (no email) 2010-12-29 18:38:03 PST
Comment on attachment 77648 [details]

I like test cases. :)
Comment 4 WebKit Commit Bot 2010-12-29 19:55:04 PST
Comment on attachment 77648 [details]

Clearing flags on attachment: 77648

Committed r74777: <http://trac.webkit.org/changeset/74777>
Comment 5 WebKit Commit Bot 2010-12-29 19:55:10 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-12-29 20:54:06 PST
http://trac.webkit.org/changeset/74777 might have broken GTK Linux 64-bit Debug
The following tests are not passing: