Bug 51617 - [GTK] Use GLib/GIO API for FileSystemGtk implementation
Summary: [GTK] Use GLib/GIO API for FileSystemGtk implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: 43878
  Show dependency tree / graph
 
Reported: 2010-12-26 07:38 PST by Martin Robinson
Modified: 2010-12-31 18:17 PST (History)
0 users

See Also:

Attachments
Patch for this issue (7.25 KB, patch)
2010-12-26 08:41 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-12-26 07:38:06 PST 
It makes sense for the GTK+ FileSystemGtk implementation to use the GIO/GLib API, since it's guaranteed to work across all GTK+ platforms. This is also a good opportunity to implement seekFile, which is missing from our implementation.
Comment 1 Martin Robinson 2010-12-26 08:41:31 PST 
Created attachment 77455 [details]
Patch for this issue
Comment 2 Xan Lopez 2010-12-31 04:43:54 PST 
Comment on attachment 77455 [details]
Patch for this issue

I have the strange feeling that I had already reviewed this. r=me
Comment 3 Martin Robinson 2010-12-31 18:17:36 PST 
Comment on attachment 77455 [details]
Patch for this issue

Clearing flags on attachment: 77455

Committed r74842: <http://trac.webkit.org/changeset/74842>
Comment 4 Martin Robinson 2010-12-31 18:17:41 PST 
All reviewed patches have been landed.  Closing bug.