Bug 51549 - commit-queue should better explain how it will re-open bugs and follow duplicate chains
Summary: commit-queue should better explain how it will re-open bugs and follow duplic...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-23 11:35 PST by Eric Seidel (no email)
Modified: 2010-12-24 03:05 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.24 KB, patch)
2010-12-23 11:38 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-12-23 11:35:11 PST 
commit-queue should better explain how it will re-open bugs and follow duplicate chains
Comment 1 Eric Seidel (no email) 2010-12-23 11:38:33 PST 
Created attachment 77353 [details]
Patch
Comment 2 David Levin 2010-12-23 21:13:27 PST 
Comment on attachment 77353 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77353&action=review

> Tools/Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:122
> +If you would like to track this test fix with another bug, please close this bug as a duplicate.  The bots will follow the duplicate chain when making future comments.

I wonder if this should be a common string within this unit test.

Feel free to ignore this.
Comment 3 Eric Seidel (no email) 2010-12-24 00:43:34 PST 
(In reply to comment #2)
> (From update of attachment 77353 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=77353&action=review
> 
> > Tools/Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:122
> > +If you would like to track this test fix with another bug, please close this bug as a duplicate.  The bots will follow the duplicate chain when making future comments.
> 
> I wonder if this should be a common string within this unit test.
> 
> Feel free to ignore this.

Certainly could be.  I don't expect to have more tests which dump the create-bug text, bug if they do, I'll make a a common string when I add a 3rd.
Comment 4 WebKit Commit Bot 2010-12-24 03:05:40 PST 
Comment on attachment 77353 [details]
Patch

Clearing flags on attachment: 77353

Committed r74623: <http://trac.webkit.org/changeset/74623>
Comment 5 WebKit Commit Bot 2010-12-24 03:05:46 PST 
All reviewed patches have been landed.  Closing bug.