WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
51542
Web Inspector: Missing Localized Strings
https://bugs.webkit.org/show_bug.cgi?id=51542
Summary
Web Inspector: Missing Localized Strings
Joseph Pecoraro
Reported
2010-12-23 10:21:42 PST
As seen on the build bot:
http://build.webkit.org/results/GTK%20Linux%2032-bit%20Release/r74563%20(8973)/inspector/syntax-highlight-html-stderr.txt
• I did not search deeply for other strings. • I did not search to see if any strings are no longer needed.
Attachments
[PATCH] Adds the missing strings
(1.09 KB, patch)
2010-12-23 10:24 PST
,
Joseph Pecoraro
yurys
: review+
joepeck
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1
2010-12-23 10:24:27 PST
Created
attachment 77343
[details]
[PATCH] Adds the missing strings Can't commit queue git delta binary patches.
Joseph Pecoraro
Comment 2
2010-12-23 16:51:39 PST
No-one reviewed this and I had some spare time. I did a quick check to verify that the strings listed in localizedStrings.js are still valid. Here is what I found: No longer seem to be used: "%s (%s transferred)" "Enable resource tracking" "Enabling resource tracking will reload the page and make page loading slower." "Resource tracking disabled. Click to enable." "Resource tracking enabled. Click to disable." "You need to enable resource tracking to use this panel." "GRAPHS" "Prototype" "RESOURCES" "Recording…" "Sort by Duration" "Sort by End Time" "Sort by Latency" "Sort by Response Time" "Sort by Size" "Sort by Start Time" "Sort by Transfer Size" "Stop on Attributes Modifications" "Stop on Node Removal" "Stop on Subtree Modifications" "Any Request" "Set XHR Breakpoint" "Timing." Might be used? Its a key in WebInspector.Resource.Type "Media" Used, but is different in Source Code: "Assertion failed: "
Yury Semikhatsky
Comment 3
2010-12-24 00:28:41 PST
(In reply to
comment #2
)
> No-one reviewed this and I had some spare time. I did a quick check to > Used, but is different in Source Code: > "Assertion failed: "
This one must be my fault. I recently changed the code that formats console messages. Will look into it.
Yury Semikhatsky
Comment 4
2010-12-24 09:02:13 PST
Committed
r74635
: <
http://trac.webkit.org/changeset/74635
>
Joseph Pecoraro
Comment 5
2011-01-10 22:23:34 PST
Thanks for landing this for me! I'll file a new bug with the comment I had about the other localized strings.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug