Bug 51530 - [EFL] Fix ContextMenu removal
Summary: [EFL] Fix ContextMenu removal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Lucas De Marchi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-23 03:35 PST by Lucas De Marchi
Modified: 2010-12-23 06:41 PST (History)
4 users (show)

See Also:

Attachments
Patch (6.48 KB, patch)
2010-12-23 03:38 PST, Lucas De Marchi 		no flags Details | Formatted Diff | Diff
Patch (6.49 KB, patch)
2010-12-23 04:19 PST, Lucas De Marchi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas De Marchi 2010-12-23 03:35:13 PST 
[EFL] Fix ContextMenu removal
Comment 1 Lucas De Marchi 2010-12-23 03:38:34 PST 
Created attachment 77321 [details]
Patch
Comment 2 WebKit Review Bot 2010-12-23 03:39:20 PST 
Attachment 77321 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'WebKit/efl/ChangeLog', u'WebKit/efl/ewk/ewk_contextmenu.cpp', u'WebKit/efl/ewk/ewk_private.h', u'WebKit/efl/ewk/ewk_view.cpp', u'cmake/OptionsEfl.cmake']" exit_code: 1
ChangeLog:21:  Line contains tab character.  [whitespace/tab] [5]
WebKit/efl/ChangeLog:21:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Lucas De Marchi 2010-12-23 04:19:43 PST 
Created attachment 77326 [details]
Patch
Comment 4 WebKit Commit Bot 2010-12-23 06:41:44 PST 
Comment on attachment 77326 [details]
Patch

Clearing flags on attachment: 77326

Committed r74556: <http://trac.webkit.org/changeset/74556>
Comment 5 WebKit Commit Bot 2010-12-23 06:41:50 PST 
All reviewed patches have been landed.  Closing bug.