Bug 51520 – [EFL] Remove warning messages during the webkit efl compiling

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Gyuyoung Kim]

There are warning messages during the webkit efl compiling. I fix them except for tiled backing store files. Because, I think they should be fixed by the tiled backing store owner.



[100%] Building C object WebKit/CMakeFiles/ewebkit.dir/efl/ewk/ewk_tiled_backing_store.c.o
[100%] Building C object WebKit/CMakeFiles/ewebkit.dir/efl/ewk/ewk_tiled_matrix.c.o
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c: In function ‘_ewk_tiled_backing_store_item_fill’:
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:553: warning: comparison between signed and unsigned integer expressions
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:553: warning: comparison between signed and unsigned integer expressions
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:566: warning: comparison between signed and unsigned integer expressions
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:567: warning: comparison between signed and unsigned integer expressions
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:575: warning: comparison between signed and unsigned integer expressions
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:575: warning: comparison between signed and unsigned integer expressions
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:580: warning: comparison between signed and unsigned integer expressions
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:581: warning: comparison between signed and unsigned integer expressions
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c: In function ‘_ewk_tiled_backing_store_smart_calculate’:
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:1462: warning: comparison between signed and unsigned integer expressions
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:1464: warning: comparison between signed and unsigned integer expressions
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c: At top level:
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:526: warning: ‘_ewk_tiled_backing_store_tile_is_inside_viewport’ defined but not used
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_backing_store.c:533: warning: ‘_ewk_tiled_backing_store_tile_is_adjacent_to_viewport’ defined but not used
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_matrix.c: In function ‘_ewk_tile_matrix_slicer_setup’:
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_matrix.c:603: warning: comparison between signed and unsigned integer expressions
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_tiled_matrix.c:605: warning: comparison between signed and unsigned integer expressions
[100%] Building C object WebKit/CMakeFiles/ewebkit.dir/efl/ewk/ewk_tiled_model.c.o
[100%] Building CXX object WebKit/CMakeFiles/ewebkit.dir/efl/ewk/ewk_util.cpp.o
[100%] Building CXX object WebKit/CMakeFiles/ewebkit.dir/efl/ewk/ewk_view.cpp.o
[100%] Building C object WebKit/CMakeFiles/ewebkit.dir/efl/ewk/ewk_view_single.c.o
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view_single.c:31: warning: missing initializer
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view_single.c:31: warning: (near initialization for ‘_parent_sc.navigation_policy_decision’)
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view_single.c: In function ‘_ewk_view_single_smart_class_new’:
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view_single.c:569: warning: missing initializer
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view_single.c:569: warning: (near initialization for ‘api.navigation_policy_decision’)
[100%] Building C object WebKit/CMakeFiles/ewebkit.dir/efl/ewk/ewk_view_tiled.c.o
[100%] /home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view_tiled.c:30: warning: missing initializer
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view_tiled.c:30: warning: (near initialization for ‘_parent_sc.navigation_policy_decision’)
Building CXX object WebKit/CMakeFiles/ewebkit.dir/efl/ewk/ewk_window_features.cpp.o
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view_tiled.c: In function ‘_ewk_view_tiled_smart_class_new’:
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view_tiled.c:274: warning: missing initializer
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view_tiled.c:274: warning: (near initialization for ‘api.navigation_policy_decision’)
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view.cpp: In function ‘void _ewk_view_smart_show(Evas_Object*)’:
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view.cpp:867: warning: unused variable ‘priv’
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view.cpp: In function ‘void _ewk_view_smart_hide(Evas_Object*)’:
/home/gyuyoung/webkit/working-source/WebKit-video/WebKit/efl/ewk/ewk_view.cpp:877: warning: unused variable ‘priv’
Linking CXX shared library libewebkit.so
[100%] Built target ewebkit
Scanning dependencies of target EWebLauncher
[100%] Building C object CMakeFiles/Programs/EWebLauncher.dir/Tools/EWebLauncher/main.c.o
Linking CXX executable Programs/EWebLauncher
[100%] Built target Programs/EWebLauncher

[Gyuyoung Kim]

Created attachment 77304 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 77304 [details]
Patch

Rejecting attachment 77304 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 77304]" exit_code: 1
Last 500 characters of output:
=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=51520&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Updating working directory
Processing patch 77304 from bug 51520.
NOBODY (OOPS!) found in /mnt/git/webkit-commit-queue/WebKit/efl/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/WebKit/efl/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/7323097

[Gyuyoung Kim]

Created attachment 77310 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 77310 [details]
Patch

Clearing flags on attachment: 77310

Committed r74542: <http://trac.webkit.org/changeset/74542>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.