WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
51507
[Chromium] Add WebThemeEngine for Mac to allow scrollbar rendering to be overridden for the DRT
https://bugs.webkit.org/show_bug.cgi?id=51507
Summary
[Chromium] Add WebThemeEngine for Mac to allow scrollbar rendering to be over...
Mihai Parparita
Reported
2010-12-22 16:33:19 PST
[Chromium] Add WebThemeEngine for Mac to allow scrollbar rendering to be overridden for the DRT
Attachments
Patch
(13.64 KB, patch)
2010-12-22 16:43 PST
,
Mihai Parparita
no flags
Details
Formatted Diff
Diff
Patch for landing
(14.24 KB, patch)
2010-12-23 10:34 PST
,
Mihai Parparita
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Mihai Parparita
Comment 1
2010-12-22 16:43:54 PST
Created
attachment 77276
[details]
Patch
Mihai Parparita
Comment 2
2010-12-22 16:59:05 PST
Chromium side is at
http://codereview.chromium.org/6041005
Mihai Parparita
Comment 3
2010-12-22 17:06:22 PST
+Kent since he reviewed the Linux version of WebThemeEngine (
http://trac.webkit.org/changeset/69311
).
Kent Tamura
Comment 4
2010-12-23 04:40:01 PST
Comment on
attachment 77276
[details]
Patch Looks good.
Kent Tamura
Comment 5
2010-12-23 04:42:46 PST
Comment on
attachment 77276
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=77276&action=review
> WebKit/chromium/public/mac/WebThemeEngine.h:1 > +/*
We should add this file to WebKit.gyp.
Mihai Parparita
Comment 6
2010-12-23 10:34:35 PST
Created
attachment 77346
[details]
Patch for landing
Mihai Parparita
Comment 7
2010-12-23 10:35:05 PST
(In reply to
comment #5
)
> We should add this file to WebKit.gyp.
Done.
WebKit Commit Bot
Comment 8
2010-12-23 14:24:16 PST
Comment on
attachment 77346
[details]
Patch for landing Clearing flags on attachment: 77346 Committed
r74581
: <
http://trac.webkit.org/changeset/74581
>
WebKit Commit Bot
Comment 9
2010-12-23 14:24:24 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 10
2010-12-23 14:59:35 PST
http://trac.webkit.org/changeset/74581
might have broken GTK Linux 64-bit Debug
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug