WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 51406
[Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
https://bugs.webkit.org/show_bug.cgi?id=51406
Summary
[Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
Mihai Parparita
Reported
2010-12-21 10:23:46 PST
We'll need a WebThemeEngine for the Chromium/Mac DRT (to match the Mac DRT's scrollabars, see discussion on
bug 51151
), so the existing Skia-based implementation should be renamed to *DRTWin to avoid confusion.
Attachments
Patch
(2.95 KB, patch)
2010-12-21 10:26 PST
,
Mihai Parparita
fishd
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mihai Parparita
Comment 1
2010-12-21 10:26:50 PST
Created
attachment 77129
[details]
Patch
Mihai Parparita
Comment 2
2010-12-21 10:45:34 PST
I'm having trouble getting webkit-patch upload to show the edits that I did after the move (I did the move with git mv). Any ideas?
Mihai Parparita
Comment 3
2010-12-21 11:00:31 PST
It looks like locally the changes are correct, it's just webkit-patch that's confused. This should be OK if I land locally.
Mihai Parparita
Comment 4
2010-12-21 12:16:02 PST
Committed
r74421
: <
http://trac.webkit.org/changeset/74421
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug