Bug 51406 - [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
Summary: [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mihai Parparita
URL:
Keywords:
Depends on:
Blocks: 51151
  Show dependency treegraph
 
Reported: 2010-12-21 10:23 PST by Mihai Parparita
Modified: 2010-12-21 12:16 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.95 KB, patch)
2010-12-21 10:26 PST, Mihai Parparita
fishd: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Parparita 2010-12-21 10:23:46 PST
We'll need a WebThemeEngine for the Chromium/Mac DRT (to match the Mac DRT's scrollabars, see discussion on bug 51151), so the existing Skia-based implementation should be renamed to *DRTWin to avoid confusion.
Comment 1 Mihai Parparita 2010-12-21 10:26:50 PST
Created attachment 77129 [details]
Patch
Comment 2 Mihai Parparita 2010-12-21 10:45:34 PST
I'm having trouble getting webkit-patch upload to show the edits that I did after the move (I did the move with git mv). Any ideas?
Comment 3 Mihai Parparita 2010-12-21 11:00:31 PST
It looks like locally the changes are correct, it's just webkit-patch that's confused. This should be OK if I land locally.
Comment 4 Mihai Parparita 2010-12-21 12:16:02 PST
Committed r74421: <http://trac.webkit.org/changeset/74421>