Bug 51360 - [chromium] Media player styles being overridden
Summary: [chromium] Media player styles being overridden
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-12-20 15:56 PST by Steve Lacey
Modified: 2010-12-20 19:21 PST (History)
3 users (show)

See Also:

Patch (2.39 KB, patch)
2010-12-20 16:37 PST, Steve Lacey
no flags Details | Formatted Diff | Diff
Patch (2.41 KB, patch)
2010-12-20 16:55 PST, Steve Lacey
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Lacey 2010-12-20 15:56:26 PST
media/controls-styling.html is failing for chromium due to missing base styles in mediaControlsChromium.css. Fix is underway.
Comment 1 Steve Lacey 2010-12-20 16:37:58 PST
Created attachment 77053 [details]
Comment 2 WebKit Review Bot 2010-12-20 16:42:03 PST
Attachment 77053 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/css/mediaControlsChromium.css']" exit_code: 1
WebCore/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 3 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 David Levin 2010-12-20 16:50:50 PST
Comment on attachment 77053 [details]

Tabs in changelog (and this needs to be perfect to go through the commit queue).
Comment 4 Steve Lacey 2010-12-20 16:55:24 PST
Created attachment 77056 [details]
Comment 5 WebKit Commit Bot 2010-12-20 18:25:04 PST
Comment on attachment 77056 [details]

Clearing flags on attachment: 77056

Committed r74381: <http://trac.webkit.org/changeset/74381>
Comment 6 WebKit Commit Bot 2010-12-20 18:25:11 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Commit Bot 2010-12-20 19:21:54 PST
The commit-queue encountered the following flaky tests while processing attachment 77056 [details]:

fast/loader/recursive-before-unload-crash.html bug 50880 (authors: beidson@apple.com and eric@webkit.org)
fast/preloader/script.html bug 50879 (author: abarth@webkit.org)
The commit-queue is continuing to process your patch.