Bug 51305 - Remove m_drawsContents from RenderSVGContainer.h
Summary: Remove m_drawsContents from RenderSVGContainer.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Rob Buis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-19 09:33 PST by Rob Buis
Modified: 2010-12-21 00:59 PST (History)
2 users (show)

See Also:


Attachments
Patch (5.79 KB, patch)
2010-12-19 10:21 PST, Rob Buis
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2010-12-19 09:33:34 PST
IIRC this was introduced to keep markers from being drawn directly, but we have other mechanisms for that now.
Comment 1 Rob Buis 2010-12-19 10:21:44 PST
Created attachment 76957 [details]
Patch
Comment 2 Andreas Kling 2010-12-19 10:37:41 PST
Comment on attachment 76957 [details]
Patch

LGTM!
Comment 3 Eric Seidel (no email) 2010-12-21 00:55:50 PST
Attachment 76957 [details] was posted by a committer and has review+, assigning to Rob Buis for commit.
Comment 4 Rob Buis 2010-12-21 00:57:48 PST
Hi Eric,

(In reply to comment #3)
> Attachment 76957 [details] was posted by a committer and has review+, assigning to Rob Buis for commit.

You need new glasses :) See r74325.
Cheers,

Rob.
Comment 5 Eric Seidel (no email) 2010-12-21 00:59:16 PST
Please close your bugs after you commit them.  Tools like webkit-patch land will dot hat for you. :)  Closing.