Bug 51275 - DrawingAreaProxy::setSize shouldn't be a virtual member function
Summary: DrawingAreaProxy::setSize shouldn't be a virtual member function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-17 14:03 PST by Anders Carlsson
Modified: 2011-01-11 10:32 PST (History)
0 users

See Also:

Attachments
Patch (9.20 KB, patch)
2010-12-17 14:04 PST, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-12-17 14:03:18 PST 
DrawingAreaProxy::setSize shouldn't be a virtual member function
Comment 1 Anders Carlsson 2010-12-17 14:04:24 PST 
Created attachment 76906 [details]
Patch
Comment 2 Sam Weinig 2010-12-17 14:07:09 PST 
Comment on attachment 76906 [details]
Patch

sizeDidChange() is never called. r-.
Comment 3 Sam Weinig 2010-12-17 14:08:23 PST 
Comment on attachment 76906 [details]
Patch

Anders has assured me he just didn't save it and the call is really there. r=me
Comment 4 Anders Carlsson 2011-01-11 10:32:12 PST 
Committed r74294: <http://trac.webkit.org/changeset/74294>