Bug 51171 - [GTK] Wrong check in ResourceHandleSoup in error cases
Summary: [GTK] Wrong check in ResourceHandleSoup in error cases
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-16 01:56 PST by Sergio Villar Senin
Modified: 2010-12-17 04:46 PST (History)
0 users

See Also:

Attachments
Patch (1.68 KB, patch)
2010-12-16 02:04 PST, Sergio Villar Senin 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2010-12-16 01:56:09 PST 
Wrong check in ResourceHandleSoup in error cases
Comment 1 Sergio Villar Senin 2010-12-16 02:04:55 PST 
Created attachment 76744 [details]
Patch
Comment 2 Sergio Villar Senin 2010-12-16 02:08:38 PST 
BTW the crash was previously see here https://bugs.webkit.org/show_bug.cgi?id=51104#c2.

This patch does not fix the test (as it needs authentication challenge support in WebKitGtk+) but it fixes the crash.
Comment 3 Martin Robinson 2010-12-16 07:34:17 PST 
Comment on attachment 76744 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76744&action=review

> WebCore/platform/network/soup/ResourceHandleSoup.cpp:-512
>              // WebCore might have cancelled the job in the while
> -            if (!d->m_cancelled && soupMsg->response_body->data)

Better leave a comment here before landing this which explains the issue.
Comment 4 Sergio Villar Senin 2010-12-17 04:46:52 PST 
Committed r74251: <http://trac.webkit.org/changeset/74251>