Bug 50864 - commit-queue flaky test messages show cryptic version information for mac os x
Summary: commit-queue flaky test messages show cryptic version information for mac os x
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-10 22:00 PST by Eric Seidel (no email)
Modified: 2010-12-10 22:47 PST (History)
7 users (show)

See Also:

Attachments
Patch (6.35 KB, patch)
2010-12-10 22:03 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-12-10 22:00:00 PST 
commit-queue flaky test messages show cryptic version information for mac os x
Comment 1 Eric Seidel (no email) 2010-12-10 22:03:32 PST 
Created attachment 76293 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-12-10 22:04:08 PST 
https://bugs.webkit.org/show_bug.cgi?id=50863#c0 is an example of the current cryptic version information.
Comment 3 Adam Barth 2010-12-10 22:27:55 PST 
Comment on attachment 76293 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76293&action=review

> WebKitTools/Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:92
> -        self.assertEqual(reporter._bot_information(), "Bot Id: MockBotId Port: MockPort OS: MockPlatform 1.0")
> +        self.assertEqual(reporter._bot_information(), "Bot: MockBotId  Port: MockPort  Platform: MockPlatform 1.0")

Seems like there's an extra space here.
Comment 4 Eric Seidel (no email) 2010-12-10 22:30:07 PST 
Comment on attachment 76293 [details]
Patch

I intentionally added an extra space between the various pieces.  Before "Mac" and "OS" blurred together into "Mac OS", now it would read "Port: Mac  Platform: Mac OS X 10.6.5"
Comment 5 WebKit Review Bot 2010-12-10 22:47:48 PST 
Comment on attachment 76293 [details]
Patch

Clearing flags on attachment: 76293

Committed r73838: <http://trac.webkit.org/changeset/73838>
Comment 6 WebKit Review Bot 2010-12-10 22:47:55 PST 
All reviewed patches have been landed.  Closing bug.