WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
50864
commit-queue flaky test messages show cryptic version information for mac os x
https://bugs.webkit.org/show_bug.cgi?id=50864
Summary
commit-queue flaky test messages show cryptic version information for mac os x
Eric Seidel (no email)
Reported
2010-12-10 22:00:00 PST
commit-queue flaky test messages show cryptic version information for mac os x
Attachments
Patch
(6.35 KB, patch)
2010-12-10 22:03 PST
,
Eric Seidel (no email)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2010-12-10 22:03:32 PST
Created
attachment 76293
[details]
Patch
Eric Seidel (no email)
Comment 2
2010-12-10 22:04:08 PST
https://bugs.webkit.org/show_bug.cgi?id=50863#c0
is an example of the current cryptic version information.
Adam Barth
Comment 3
2010-12-10 22:27:55 PST
Comment on
attachment 76293
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=76293&action=review
> WebKitTools/Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:92 > - self.assertEqual(reporter._bot_information(), "Bot Id: MockBotId Port: MockPort OS: MockPlatform 1.0") > + self.assertEqual(reporter._bot_information(), "Bot: MockBotId Port: MockPort Platform: MockPlatform 1.0")
Seems like there's an extra space here.
Eric Seidel (no email)
Comment 4
2010-12-10 22:30:07 PST
Comment on
attachment 76293
[details]
Patch I intentionally added an extra space between the various pieces. Before "Mac" and "OS" blurred together into "Mac OS", now it would read "Port: Mac Platform: Mac OS X 10.6.5"
WebKit Review Bot
Comment 5
2010-12-10 22:47:48 PST
Comment on
attachment 76293
[details]
Patch Clearing flags on attachment: 76293 Committed
r73838
: <
http://trac.webkit.org/changeset/73838
>
WebKit Review Bot
Comment 6
2010-12-10 22:47:55 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug