Bug 50683 - REGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open Link in New Tab
Summary: REGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P1 Normal
Assignee: Brian Weinstein
URL:
Keywords: InRadar, Regression
: 50686 50693 50694 50765 50798 50812 50870 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-12-08 06:33 PST by Kevin M. Dean
Modified: 2010-12-11 10:37 PST (History)
13 users (show)

See Also:

Attachments
[PATCH] Fix (1.34 KB, patch)
2010-12-08 15:15 PST, Brian Weinstein 		sullivan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin M. Dean 2010-12-08 06:33:39 PST 
Some of the contextual menu items are non-functional:

Open Link in New Tab
Download Linked File As...
Add Link to Bookmarks...
Open Image in New Tab
Save Image As...
Save Image to "Downloads"

These still work:

Open Link in New Window
Download Linked File
Copy Link
Open Image in New Window
Comment 1 Alexey Proskuryakov 2010-12-08 13:39:59 PST 
*** Bug 50686 has been marked as a duplicate of this bug. ***
Comment 2 Alexey Proskuryakov 2010-12-08 13:41:25 PST 
Sam, was this broken by WebKit2 work?
Comment 3 Brady Eidson 2010-12-08 13:56:52 PST 
Kevin, is this in WK2, or in normal WebKit?
Comment 4 Alexey Proskuryakov 2010-12-08 14:08:49 PST 
This is about WebKit nightlies, so WebKit1.
Comment 5 Brady Eidson 2010-12-08 14:10:06 PST 
I saw no indication it was about WebKit Nightlies.

If it broke somewhere in this range since yesterday, it was almost certainly some refactoring from Brian.
Comment 6 Brian Weinstein 2010-12-08 14:19:52 PST 
(In reply to comment #5)
> I saw no indication it was about WebKit Nightlies.
> 
> If it broke somewhere in this range since yesterday, it was almost certainly some refactoring from Brian.

I believe it could be a manifestation of: https://bugs.webkit.org/show_bug.cgi?id=50665

Testing my patch to see if it fixes this issue.
Comment 7 Alexey Proskuryakov 2010-12-08 15:07:53 PST 
*** Bug 50694 has been marked as a duplicate of this bug. ***
Comment 8 Alexey Proskuryakov 2010-12-08 15:09:37 PST 
*** Bug 50693 has been marked as a duplicate of this bug. ***
Comment 9 Brian Weinstein 2010-12-08 15:15:19 PST 
Created attachment 75978 [details]
[PATCH] Fix
Comment 10 Brian Weinstein 2010-12-08 15:22:25 PST 
<rdar://problem/8746500>
Comment 11 Brian Weinstein 2010-12-08 15:34:56 PST 
Landed in r73560.
Comment 12 Alexey Proskuryakov 2010-12-09 10:00:42 PST 
*** Bug 50765 has been marked as a duplicate of this bug. ***
Comment 13 Alexey Proskuryakov 2010-12-09 22:25:09 PST 
*** Bug 50798 has been marked as a duplicate of this bug. ***
Comment 14 Alexey Proskuryakov 2010-12-10 10:58:34 PST 
*** Bug 50812 has been marked as a duplicate of this bug. ***
Comment 15 Alexey Proskuryakov 2010-12-11 10:37:22 PST 
*** Bug 50870 has been marked as a duplicate of this bug. ***