Bug 50540 - MathML: update baselinePosition() call in RenderMathMLBlock.cpp
Summary: MathML: update baselinePosition() call in RenderMathMLBlock.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-05 10:52 PST by François Sausset
Modified: 2010-12-10 02:17 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.57 KB, patch)
2010-12-05 10:59 PST, François Sausset 		ossy: review-
ossy: commit-queue-
Details | Formatted Diff | Diff
Revised patch (1.24 KB, patch)
2010-12-06 04:51 PST, François Sausset 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description François Sausset 2010-12-05 10:52:49 PST 
The call of baselinePosition() is outdated: new arguments should be added.
Comment 1 François Sausset 2010-12-05 10:59:17 PST 
Created attachment 75633 [details]
Patch
Comment 2 Csaba Osztrogonác 2010-12-06 04:27:50 PST 
Comment on attachment 75633 [details]
Patch

You shouldn't add your own copyright entry for a one line change.
Adding copyright entry needs more than 10 (significant) line change.
Comment 3 François Sausset 2010-12-06 04:51:57 PST 
Created attachment 75676 [details]
Revised patch

Remove the copyright.
Comment 4 Eric Seidel (no email) 2010-12-10 00:06:34 PST 
Comment on attachment 75676 [details]
Revised patch

OK.
Comment 5 WebKit Commit Bot 2010-12-10 02:17:19 PST 
Comment on attachment 75676 [details]
Revised patch

Clearing flags on attachment: 75676

Committed r73698: <http://trac.webkit.org/changeset/73698>
Comment 6 WebKit Commit Bot 2010-12-10 02:17:24 PST 
All reviewed patches have been landed.  Closing bug.