Bug 50403 – --suggest-reviewers failed for attachment 75398 [details]

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: Tools / Tests

[Eric Seidel (no email)]

--suggest-reviewers failed for attachment 75398 [details] 

Traceback (most recent call last):
  File "/Projects/WebKit/WebKitTools/Scripts/webkit-patch", line 70, in <module>
    main()
  File "/Projects/WebKit/WebKitTools/Scripts/webkit-patch", line 65, in main
    WebKitPatch(__file__).main()
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 43, in execute
    self._sequence.run_and_handle_errors(tool, options, self._prepare_state(options, args, tool))
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/steps/suggestreviewers.py", line 45, in run
    reviewers = self._tool.checkout().suggested_reviewers(self._options.git_commit, self._changed_files(state))
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/api.py", line 128, in suggested_reviewers
    reviewers = [commit_info.reviewer() for commit_info in commit_infos if commit_info.reviewer()]
AttributeError: 'NoneType' object has no attribute 'reviewer'

Probably and easy fix.

[Eric Seidel (no email)]

See also bug 49158.

[David Kilzer (:ddkilzer)]

I don't think we've had any reports of this recently, so moving to RESOLVED/WFM (since there is no Config Changed status).