Bug 50021 - [Qt] Make QtTestBrowser remember the selected user agent
Summary: [Qt] Make QtTestBrowser remember the selected user agent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P4 Enhancement
Assignee: Yi Shen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-24 06:59 PST by Yi Shen
Modified: 2010-11-24 07:49 PST (History)
2 users (show)

See Also:


Attachments
proposal fix (1.07 KB, patch)
2010-11-24 07:08 PST, Yi Shen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yi Shen 2010-11-24 06:59:24 PST
From user & tester's aspect, it would be nice for QtTestBrowser to remember the selected user agent when toggling use of qgraphicswebview.
Comment 1 Yi Shen 2010-11-24 07:08:39 PST
Created attachment 74756 [details]
proposal fix
Comment 2 Andreas Kling 2010-11-24 07:12:42 PST
Comment on attachment 74756 [details]
proposal fix

Nice change indeed, r=me
Comment 3 Yi Shen 2010-11-24 07:16:00 PST
(In reply to comment #2)
> (From update of attachment 74756 [details])
> Nice change indeed, r=me

Thanks Kling, u r ninjia speed reviewer :)
Comment 4 WebKit Commit Bot 2010-11-24 07:49:14 PST
Comment on attachment 74756 [details]
proposal fix

Clearing flags on attachment: 74756

Committed r72671: <http://trac.webkit.org/changeset/72671>
Comment 5 WebKit Commit Bot 2010-11-24 07:49:19 PST
All reviewed patches have been landed.  Closing bug.