Bug 49861 - Rename WebKitTools to Tools
Summary: Rename WebKitTools to Tools
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: mitz
Depends on:
Reported: 2010-11-20 00:13 PST by mitz
Modified: 2010-12-20 13:20 PST (History)
5 users (show)

See Also:

Rename WebKitTools to Tools and update references (77.94 KB, patch)
2010-11-20 00:25 PST, mitz
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2010-11-20 00:13:31 PST
Rename WebKitTools to Tools
Comment 1 mitz 2010-11-20 00:25:03 PST
Created attachment 74473 [details]
Rename WebKitTools to Tools and update references
Comment 2 Simon Fraser (smfr) 2010-11-20 09:24:10 PST
Comment on attachment 74473 [details]
Rename WebKitTools to Tools and update references

Comment 3 Dirk Pranke 2010-11-22 14:26:05 PST
This change looks mostly fine and I think it's a great idea, but it's likely to break stuff outside of the WebKit repo. It will certainly break some wrapper scripts in Chromium that we use to minimize the dependencies of our buildbots on WebKit directory layout.

Although it looks like SVN doesn't really support symlinks on windows, did you consider the idea of adding a symlink from WebKitTools -> Tools to at least extend the transition period for other repos on non-Win platforms?
Comment 4 Jeff Miller 2010-12-20 11:46:45 PST
OpenSource/Tools/vcbin/midl.exe needs to be rebuilt as well, since it's checked in and has a hard-coded reference to the old name of this folder (WebKitTools).  Looks like the source code in MIDLWrapper.cpp was updated, but not the built tool.
Comment 5 Jeff Miller 2010-12-20 12:52:45 PST
I filed https://bugs.webkit.org/show_bug.cgi?id=51347 to rebuild midl.exe.
Comment 6 mitz 2010-12-20 13:20:56 PST