Bug 49805 – REGRESSION(r72399): Broke Chromium build (Requested by antonm_ on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/72399 broke the build:
Broke Chromium build (Requested by antonm_ on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 74389 [details]
ROLLOUT of r72399

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.

[anton muhin]

Sample of build log:

5>WebViewImpl.cpp
5>e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\webkit\javascriptcore\wtf\text\StringImpl.h(90) : warning C4355: 'this' : used in base member initializer list
5>e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\webkit\javascriptcore\wtf\text\StringImpl.h(90) : warning C4355: 'this' : used in base member initializer list
5>e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\webkit\javascriptcore\wtf\text\StringImpl.h(90) : warning C4355: 'this' : used in base member initializer list
5>e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\webkit\javascriptcore\wtf\text\StringImpl.h(90) : warning C4355: 'this' : used in base member initializer list
5>..\..\WebCore\dom\ViewportArguments.h(78) : warning C4305: 'initializing' : truncation from '' to 'bool'
5>e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\webkit\webcore\dom\ViewportArguments.h(78) : warning C4305: 'initializing' : truncation from '' to 'bool'
5>..\..\WebCore\dom\ViewportArguments.h(78) : warning C4305: 'initializing' : truncation from '' to 'bool'
5>..\..\WebCore\dom\ViewportArguments.h(78) : warning C4305: 'initializing' : truncation from '' to 'bool'
5>e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\webkit\webkit\chromium\src\WebViewImpl.h(419) : error C2259: 'WebKit::ChromeClientImpl' : cannot instantiate abstract class
5>        due to following members:
5>        'void WebCore::ChromeClientChromium::popupOpened(WebCore::PopupContainer *,const WebCore::IntRect &,bool)' : is abstract
5>        ..\..\WebCore\page\chromium\ChromeClientChromium.h(49) : see declaration of 'WebCore::ChromeClientChromium::popupOpened'
5>e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\webkit\webkit\chromium\src\WebViewImpl.h(419) : error C2259: 'WebKit::ChromeClientImpl' : cannot instantiate abstract class
5>        due to following members:
5>        'void WebCore::ChromeClientChromium::popupOpened(WebCore::PopupContainer *,const WebCore::IntRect &,bool)' : is abstract
5>        ..\..\WebCore\page\chromium\ChromeClientChromium.h(49) : see declaration of 'WebCore::ChromeClientChromium::popupOpened'
5>e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\webkit\webkit\chromium\src\WebViewImpl.h(419) : error C2259: 'WebKit::ChromeClientImpl' : cannot instantiate abstract class
5>        due to following members:
5>        'void WebCore::ChromeClientChromium::popupOpened(WebCore::PopupContainer *,const WebCore::IntRect &,bool)' : is abstract
5>        ..\..\WebCore\page\chromium\ChromeClientChromium.h(49) : see declaration of 'WebCore::ChromeClientChromium::popupOpened'

[anton muhin]

Comment on attachment 74389 [details]
ROLLOUT of r72399

Sorry, just to keep webkit rolling

[WebKit Commit Bot]

Comment on attachment 74389 [details]
ROLLOUT of r72399

Clearing flags on attachment: 74389

Committed r72403: <http://trac.webkit.org/changeset/72403>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.