WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
49535
Make ContextShadow compile on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49535
Summary
Make ContextShadow compile on all platforms
Patrick R. Gansterer
Reported
2010-11-15 04:47:44 PST
see patch
Attachments
Patch
(1.69 KB, patch)
2010-11-15 05:01 PST
,
Patrick R. Gansterer
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1
2010-11-15 05:01:07 PST
Created
attachment 73887
[details]
Patch
Martin Robinson
Comment 2
2010-11-15 07:57:48 PST
Wouldn't it be better to actually add the proper typedef for new platforms?
Patrick R. Gansterer
Comment 3
2010-11-15 08:05:40 PST
(In reply to
comment #2
)
> Wouldn't it be better to actually add the proper typedef for new platforms?
This is the same behaviour like for PlatformMenuDescription and friends. So it's possible to include ContextShadow.h without any buildproblems and we don't need to add a ifdef around it.
Martin Robinson
Comment 4
2010-11-15 08:07:27 PST
Comment on
attachment 73887
[details]
Patch Okay. Thanks.
WebKit Commit Bot
Comment 5
2010-11-15 08:25:01 PST
Comment on
attachment 73887
[details]
Patch Clearing flags on attachment: 73887 Committed
r72007
: <
http://trac.webkit.org/changeset/72007
>
WebKit Commit Bot
Comment 6
2010-11-15 08:25:07 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug