Bug 49421 - Metrics changed in fast/forms/isindex-placeholder with new parser
Summary: Metrics changed in fast/forms/isindex-placeholder with new parser
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-11 17:52 PST by Adele Peterson
Modified: 2023-06-03 21:32 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adele Peterson 2010-11-11 17:52:18 PST
When the new parser was enabled, metrics in fast/forms/isindex-placeholder changed.  The expected results were updated, but the pixel tests were not.  I can't tell if this is actually a progression.
Comment 1 Adele Peterson 2010-11-11 17:54:22 PST
To see what I mean:

run-webkit-tests --pixel fast/forms/isindex-placeholder.html
Comment 3 Eric Seidel (no email) 2010-11-11 18:06:43 PST
I expect this is an artifact of <isindex> being auto-replaced by a <form><input> DOM now:
http://www.whatwg.org/specs/web-apps/current-work/multipage/tokenization.html#parsing-main-inbody

Maybe <form> has some implicit padding after it which <isindex> did not before?
Comment 4 Eric Seidel (no email) 2010-11-11 18:09:06 PST
<isindex> turns into:
<form><hr><label><input></input></label><hr></form>

I expect there is some implicit padding on one of those.  If we compared that above dom to <isindex> in this example in SAfari 5, I expect this would be an expected change.
Comment 5 Ahmad Saleem 2023-06-03 21:32:26 PDT
Following test got deleted as well:

https://github.com/WebKit/WebKit/commit/c92f223d57abd60e7bc682985a103744f3760672

No need to do improvement in 'isindex' etc.

Changing to 'RESOLVED WONTFIX'.