Bug 49202 - Make lists work with vertical text.
Summary: Make lists work with vertical text.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 46123
  Show dependency tree / graph
 
Reported: 2010-11-08 13:17 PST by Dave Hyatt
Modified: 2010-11-09 17:46 PST (History)
0 users

See Also:

Attachments
Patch (681.64 KB, patch)
2010-11-09 14:00 PST, Dave Hyatt 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-11-08 13:17:04 PST 
List items need to work with vertical text.
Comment 1 Dave Hyatt 2010-11-09 14:00:49 PST 
Created attachment 73411 [details]
Patch
Comment 2 mitz 2010-11-09 14:22:24 PST 
Comment on attachment 73411 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73411&action=review

> WebCore/rendering/RenderListMarker.cpp:1496
> -                        marginLeft = m_text.isEmpty() ? 0 : -minPreferredLogicalWidth() - offset / 2;
> +                        marginStart = m_text.isEmpty() ? 0 : -minPreferredLogicalWidth() - offset / 2;

I’d expect this to cause some right-to-left markers to shift by 1 pixel since the remainder goes to the other side now. Maybe we don’t have any tests covering this.
Comment 3 Dave Hyatt 2010-11-09 17:46:22 PST 
Fixed in r71700.