RESOLVED FIXED 49202
Make lists work with vertical text. 
https://bugs.webkit.org/show_bug.cgi?id=49202
Summary Make lists work with vertical text.
Dave Hyatt
Reported 2010-11-08 13:17:04 PST
List items need to work with vertical text.
Attachments
Patch (681.64 KB, patch)
2010-11-09 14:00 PST, Dave Hyatt 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-11-09 14:00:49 PST
Created attachment 73411 [details] Patch
mitz
Comment 2 2010-11-09 14:22:24 PST
Comment on attachment 73411 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73411&action=review > WebCore/rendering/RenderListMarker.cpp:1496 > - marginLeft = m_text.isEmpty() ? 0 : -minPreferredLogicalWidth() - offset / 2; > + marginStart = m_text.isEmpty() ? 0 : -minPreferredLogicalWidth() - offset / 2; I’d expect this to cause some right-to-left markers to shift by 1 pixel since the remainder goes to the other side now. Maybe we don’t have any tests covering this.
Dave Hyatt
Comment 3 2010-11-09 17:46:22 PST
Fixed in r71700.
Note You need to log in before you can comment on or make changes to this bug.