Bug 49118 – Use IAccessibleComparable to compare accessibility objects.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Chris Guillory]

AccessibilityUIElement::isEqual currently isn't returning correct results on the windows platform.

[Chris Guillory]

Created attachment 73150 [details]
Patch.

[chris fleizach]

Comment on attachment 73150 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=73150&action=review

just one minor change, otherwise looks ok

> WebKitTools/DumpRenderTree/AccessibilityUIElement.h:-74
> -    

i think we should remove the #if #else, then put this default implementation in AccessibilutyUIElement.cpp as

#if !PLATFORM(WIN)
...
#endif

that way the header is easier to parse

[Chris Guillory]

Created attachment 73153 [details]
Moved default implementation to AccessibilityUIElement.cpp

[chris fleizach]

Comment on attachment 73153 [details]
Moved default implementation to AccessibilityUIElement.cpp

r=me

[WebKit Commit Bot]

Comment on attachment 73153 [details]
Moved default implementation to AccessibilityUIElement.cpp

Rejecting patch 73153 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2
Last 500 characters of output:
r `all'.

=== BUILD AGGREGATE TARGET All OF PROJECT DumpRenderTree WITH CONFIGURATION Release ===
Check dependencies
** BUILD FAILED **


The following build commands failed:
DumpRenderTree:
	CompileC /Projects/CommitQueue/WebKitBuild/DumpRenderTree.build/Release/DumpRenderTree.build/Objects-normal/x86_64/AccessibilityUIElement.o /Projects/CommitQueue/WebKitTools/DumpRenderTree/AccessibilityUIElement.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
(1 failure)

Compiling DumpRenderTree failed!

Full output: http://queues.webkit.org/results/5318017

[Chris Guillory]

Output:
/Projects/CommitQueue/WebKitTools/DumpRenderTree/AccessibilityUIElement.cpp:791: error: prototype for 'bool AccessibilityTextMarkerRange::isEqual(AccessibilityUIElement*)' does not match any in class 'AccessibilityTextMarkerRange'
/Projects/CommitQueue/WebKitTools/DumpRenderTree/AccessibilityTextMarker.h:77: error: candidate is: bool AccessibilityTextMarkerRange::isEqual(AccessibilityTextMarkerRange*)
/Projects/CommitQueue/WebKitTools/DumpRenderTree/AccessibilityUIElement.cpp: In member function 'bool AccessibilityTextMarkerRange::isEqual(AccessibilityUIElement*)':
/Projects/CommitQueue/WebKitTools/DumpRenderTree/AccessibilityUIElement.cpp:793: error: 'platformUIElement' was not declared in this scope

[WebKit Review Bot]

Attachment 73153 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/5557004

[Chris Guillory]

Created attachment 73450 [details]
Patch

Builds on non-windows now.

[Eric Seidel (no email)]

Comment on attachment 73153 [details]
Moved default implementation to AccessibilityUIElement.cpp

Cleared Chris Fleizach's review+ from obsolete attachment 73153 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[chris fleizach]

Comment on attachment 73450 [details]
Patch

r=me

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 73450 [details]:

fast/css/font-face-download-error.html
http/tests/appcache/fail-on-update-2.html

Please file bugs against the tests.  These tests were authored by [e-mail] and [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 73450 [details]
Patch

Clearing flags on attachment: 73450

Committed r71792: <http://trac.webkit.org/changeset/71792>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.