RESOLVED FIXED48850
[chromium] GraphicsContext3D creation attributes include canRecoverFromContextLoss option 
https://bugs.webkit.org/show_bug.cgi?id=48850
Summary [chromium] GraphicsContext3D creation attributes include canRecoverFromContex...
Vincent Scheib
Reported 2010-11-02 10:48:38 PDT
[chromium] GraphicsContext3D creation attributes include canRecoverFromContextLoss option
Attachments
Patch (5.21 KB, patch)
2010-11-02 11:14 PDT, Vincent Scheib 		no flags
DetailsFormatted DiffDiff
Patch (5.22 KB, patch)
2010-11-02 16:49 PDT, Vincent Scheib 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vincent Scheib
Comment 1 2010-11-02 11:14:40 PDT
Created attachment 72701 [details] Patch
James Robinson
Comment 2 2010-11-02 15:43:09 PDT
Comment on attachment 72701 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72701&action=review Looks good. Nit on a comment. > WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp:55 > + attr.canRecoverFromContextLoss = false; // canvas contexts can not handle lost contexts Leading caps, trailing period.
Vincent Scheib
Comment 3 2010-11-02 16:49:50 PDT
Created attachment 72768 [details] Patch
WebKit Commit Bot
Comment 4 2010-11-03 19:41:45 PDT
The commit-queue encountered the following flaky tests while processing attachment 72768 [details]: http/tests/websocket/tests/multiple-connections.html Please file bugs against the tests. These tests were authored by abarth@webkit.org. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2010-11-03 19:42:44 PDT
Comment on attachment 72768 [details] Patch Clearing flags on attachment: 72768 Committed r71299: <http://trac.webkit.org/changeset/71299>
WebKit Commit Bot
Comment 6 2010-11-03 19:42:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.