Bug 48850 - [chromium] GraphicsContext3D creation attributes include canRecoverFromContextLoss option
Summary: [chromium] GraphicsContext3D creation attributes include canRecoverFromContex...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-02 10:48 PDT by Vincent Scheib
Modified: 2010-11-03 19:42 PDT (History)
2 users (show)

See Also:


Attachments
Patch (5.21 KB, patch)
2010-11-02 11:14 PDT, Vincent Scheib
no flags Details | Formatted Diff | Diff
Patch (5.22 KB, patch)
2010-11-02 16:49 PDT, Vincent Scheib
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Scheib 2010-11-02 10:48:38 PDT
[chromium] GraphicsContext3D creation attributes include canRecoverFromContextLoss option
Comment 1 Vincent Scheib 2010-11-02 11:14:40 PDT
Created attachment 72701 [details]
Patch
Comment 2 James Robinson 2010-11-02 15:43:09 PDT
Comment on attachment 72701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72701&action=review

Looks good.  Nit on a comment.

> WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp:55
> +    attr.canRecoverFromContextLoss = false; // canvas contexts can not handle lost contexts

Leading caps, trailing period.
Comment 3 Vincent Scheib 2010-11-02 16:49:50 PDT
Created attachment 72768 [details]
Patch
Comment 4 WebKit Commit Bot 2010-11-03 19:41:45 PDT
The commit-queue encountered the following flaky tests while processing attachment 72768 [details]:

http/tests/websocket/tests/multiple-connections.html

Please file bugs against the tests.  These tests were authored by abarth@webkit.org.  The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2010-11-03 19:42:44 PDT
Comment on attachment 72768 [details]
Patch

Clearing flags on attachment: 72768

Committed r71299: <http://trac.webkit.org/changeset/71299>
Comment 6 WebKit Commit Bot 2010-11-03 19:42:49 PDT
All reviewed patches have been landed.  Closing bug.