Bug 48208 - Inline WTF::bitCount
Summary: Inline WTF::bitCount
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
Depends on:
Blocks: 32828
  Show dependency treegraph
Reported: 2010-10-24 09:09 PDT by Patrick R. Gansterer
Modified: 2010-10-24 11:53 PDT (History)
3 users (show)

See Also:

Patch (2.17 KB, patch)
2010-10-24 09:11 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-10-24 09:09:41 PDT
see patch
Comment 1 Patrick R. Gansterer 2010-10-24 09:11:19 PDT
Created attachment 71689 [details]
Comment 2 WebKit Review Bot 2010-10-24 09:15:10 PDT
Attachment 71689 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/wtf/StdLibExtras.h:94:  bitwise_cast is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 David Kilzer (:ddkilzer) 2010-10-24 09:37:25 PDT
Comment on attachment 71689 [details]

Thanks!  r=me
Comment 4 WebKit Commit Bot 2010-10-24 11:53:41 PDT
Comment on attachment 71689 [details]

Clearing flags on attachment: 71689

Committed r70419: <http://trac.webkit.org/changeset/70419>
Comment 5 WebKit Commit Bot 2010-10-24 11:53:46 PDT
All reviewed patches have been landed.  Closing bug.