Bug 48093 - EWS does not need to process obsolete patches
Summary: EWS does not need to process obsolete patches
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 35460
  Show dependency tree / graph
 
Reported: 2010-10-21 15:01 PDT by Eric Seidel (no email)
Modified: 2010-10-22 13:19 PDT (History)
5 users (show)

See Also:

Attachments
wip (1.53 KB, patch)
2010-10-21 15:02 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Patch (18.53 KB, patch)
2010-10-22 12:47 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-10-21 15:01:06 PDT 
EWS does not need to process obsolete patches
Comment 1 Eric Seidel (no email) 2010-10-21 15:02:34 PDT 
Created attachment 71499 [details]
wip
Comment 2 Eric Seidel (no email) 2010-10-22 12:47:46 PDT 
Created attachment 71585 [details]
Patch
Comment 3 Adam Barth 2010-10-22 12:56:00 PDT 
Comment on attachment 71585 [details]
Patch

Hum...  Feels like a big testing tax.
Comment 4 Eric Seidel (no email) 2010-10-22 13:03:03 PDT 
I'm not sure what you mean.   Are you suggesting that our shared fixtures are a burden?  I would agree they are, but the problem is that if we don't use them then we get in to the problems that this patch fixes: of having one part of the code look at one fixture while another looks at different one.  Using shared fixtures throughout makes this problem go away, but does cause our tests to be tightly coupled and make changing those central fixures more painful.
Comment 5 Adam Barth 2010-10-22 13:08:23 PDT 
I just meant that the ratio of code change to test change was really out of whack in this patch.  I think you're improving things so that will be less the case going forward, but we need to watch this stuff to make sure new code and new tests won't have the same problem.
Comment 6 WebKit Commit Bot 2010-10-22 13:19:32 PDT 
Comment on attachment 71585 [details]
Patch

Clearing flags on attachment: 71585

Committed r70328: <http://trac.webkit.org/changeset/70328>
Comment 7 WebKit Commit Bot 2010-10-22 13:19:38 PDT 
All reviewed patches have been landed.  Closing bug.