Bug 48081 - Regression (r69548): cancelled autocorrection suggestion is still applied.
Summary: Regression (r69548): cancelled autocorrection suggestion is still applied.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.6
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 47630
  Show dependency treegraph
 
Reported: 2010-10-21 11:42 PDT by Jia Pu
Modified: 2010-10-22 09:11 PDT (History)
2 users (show)

See Also:


Attachments
Proposed Patch (v1) (3.14 KB, patch)
2010-10-21 13:30 PDT, Jia Pu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jia Pu 2010-10-21 11:42:50 PDT
Similar to the regression reported in bug 47689, after the patch r69548, even after user pressed ESC to cancel autocorrection panel, the correction suggestion is still applied.

<rdar://problem/8579765>
Comment 1 Jia Pu 2010-10-21 13:30:02 PDT
Created attachment 71480 [details]
Proposed Patch (v1)
Comment 2 WebKit Commit Bot 2010-10-22 08:52:22 PDT
Comment on attachment 71480 [details]
Proposed Patch (v1)

Rejecting patch 71480 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'land-attachment', '--force-clean', '--ignore-builders', '--quiet', '--non-interactive', '--parent-command=commit-queue', 71480]" exit_code: 1
Last 500 characters of output:
on=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=48081&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Updating working directory
Processing patch 71480 from bug 48081.
NOBODY (OOPS!) found in /Users/abarth/git/webkit-queue/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /Users/abarth/git/webkit-queue/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/4718021
Comment 3 WebKit Commit Bot 2010-10-22 09:11:50 PDT
Comment on attachment 71480 [details]
Proposed Patch (v1)

Clearing flags on attachment: 71480

Committed r70310: <http://trac.webkit.org/changeset/70310>
Comment 4 WebKit Commit Bot 2010-10-22 09:11:55 PDT
All reviewed patches have been landed.  Closing bug.