Bug 48026 – SVGStyledTransformableElement supplemental transforms pre-multiplied but should be post-multiplied.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Shane Stephens]

SVGStyledTransformableElement supplemental transforms pre-multiplied but should be post-multiplied.

[Shane Stephens]

Created attachment 71369 [details]
Patch

[Dirk Schulze]

Comment on attachment 71369 [details]
Patch

Same like in bug 48215.
Does this only apply to elements with local transform in combination of animateMotion, what about animateTransform? If you need animation tests, you should use the animation test api in svg/animations. Please take a look there. Using setTimeout is definitely wrong.
If it does not only effect animateMotion, I'd like to see more tests.

[Shane Stephens]

This bug does not affect animateTransform as animateTransform appends or replaces the target element's transformList directly, whereas animateMotion acts via the m_supplementalTransform member of SVGStyledTransformableElements.

[Shane Stephens]

Created attachment 72390 [details]
Patch

[Nikolas Zimmermann]

Comment on attachment 72390 [details]
Patch

Excellent job. I guess you're fixing operator* afterwards?

[Shane Stephens]

Yep, I'm tracking that in 48031

[WebKit Commit Bot]

Comment on attachment 72390 [details]
Patch

Rejecting patch 72390 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2
Last 500 characters of output:
......................................................................................................................................................................................................................................
svg/animations .....
svg/animations/animate-path-nested-transforms.html -> failed

Exiting early after 1 failures. 18548 tests run.
351.80s total testing time

18547 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
9 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/4764089

[Shane Stephens]

Created attachment 72861 [details]
Patch

[Shane Stephens]

The layout test was failing on the commit queue because run-webkit-tests (which the commit queue uses) is less permissive about newlines at the end of the expectations file than new-run-webkit-tests (which I was using) is.  That problem is fixed in the latest patch.

[Shane Stephens]

tony: patch is identical to the previous r+'d one except for an extra newline at the end of the test expectations, and slightly looser tolerances for the location of the object at the start and end of the animation.

[Tony Chang]

Comment on attachment 72861 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72861&action=review

> LayoutTests/svg/animations/script-tests/animate-path-nested-transforms.js:47
> +    const expectedValues = [

const?

[WebKit Commit Bot]

Comment on attachment 72861 [details]
Patch

Clearing flags on attachment: 72861

Committed r71314: <http://trac.webkit.org/changeset/71314>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/71314 might have broken Qt Linux Release