We should either update panel externally or make it listen to resources.
Created attachment 71147 [details] [PATCH] Proposed change.
Comment on attachment 71147 [details] [PATCH] Proposed change. View in context: https://bugs.webkit.org/attachment.cgi?id=71147&action=review Nice change. > WebCore/inspector/front-end/ResourcesPanel.js:1078 > + return resourceView.__proto__ === WebInspector.SourceView.prototype; Why not check for (resourceView instanceof WebInspector.SourceView) instead? > WebCore/inspector/front-end/ResourcesPanel.js:1080 > + return resourceView.__proto__ === WebInspector.ImageView.prototype; ditto > WebCore/inspector/front-end/ResourcesPanel.js:1082 > + return resourceView.__proto__ === WebInspector.FontView.prototype; ditto > WebCore/inspector/front-end/ResourcesPanel.js:1084 > + return resourceView.__proto__ === WebInspector.ResourceView.prototype; ditto
(In reply to comment #2) > (From update of attachment 71147 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=71147&action=review > > Nice change. > > > WebCore/inspector/front-end/ResourcesPanel.js:1078 > > + return resourceView.__proto__ === WebInspector.SourceView.prototype; > > Why not check for (resourceView instanceof WebInspector.SourceView) instead? > instanceof ResourceView would be true for all of them and I don't want that...
Comment on attachment 71147 [details] [PATCH] Proposed change. Clearing flags on attachment: 71147 Committed r70045: <http://trac.webkit.org/changeset/70045>
All reviewed patches have been landed. Closing bug.