Bug 47892 – Web Inspector: do not access ResourcePanel from resources directly.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

We should either update panel externally or make it listen to resources.

[Pavel Feldman]

Created attachment 71147 [details]
[PATCH] Proposed change.

[Yury Semikhatsky]

Comment on attachment 71147 [details]
[PATCH] Proposed change.

View in context: https://bugs.webkit.org/attachment.cgi?id=71147&action=review

Nice change.

> WebCore/inspector/front-end/ResourcesPanel.js:1078
> +                return resourceView.__proto__ === WebInspector.SourceView.prototype;

Why not check for (resourceView instanceof WebInspector.SourceView) instead?

> WebCore/inspector/front-end/ResourcesPanel.js:1080
> +                return resourceView.__proto__ === WebInspector.ImageView.prototype;

ditto

> WebCore/inspector/front-end/ResourcesPanel.js:1082
> +                return resourceView.__proto__ === WebInspector.FontView.prototype;

ditto

> WebCore/inspector/front-end/ResourcesPanel.js:1084
> +                return resourceView.__proto__ === WebInspector.ResourceView.prototype;

ditto

[Pavel Feldman]

(In reply to comment #2)
> (From update of attachment 71147 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=71147&action=review
> 
> Nice change.
> 
> > WebCore/inspector/front-end/ResourcesPanel.js:1078
> > +                return resourceView.__proto__ === WebInspector.SourceView.prototype;
> 
> Why not check for (resourceView instanceof WebInspector.SourceView) instead?
> 

instanceof ResourceView would be true for all of them and I don't want that...

[WebKit Commit Bot]

Comment on attachment 71147 [details]
[PATCH] Proposed change.

Clearing flags on attachment: 71147

Committed r70045: <http://trac.webkit.org/changeset/70045>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.