Bug 47804 - [Qt] Correct initial state of ImageBuffer QPen
Summary: [Qt] Correct initial state of ImageBuffer QPen
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: QtWebKit Unassigned
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-10-18 01:24 PDT by Andreas Kling
Modified: 2010-10-19 06:31 PDT (History)
3 users (show)

See Also:


Attachments
Proposed patch (1.16 KB, patch)
2010-10-18 01:25 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-10-18 01:24:19 PDT
The QPen on the ImageBuffer should start in the Qt::SvgMiterJoin line join mode.

This is already enforced by the GraphicsContext constructor but there's no harm in consistency..
Comment 1 Andreas Kling 2010-10-18 01:25:30 PDT
Created attachment 71009 [details]
Proposed patch
Comment 2 Andreas Kling 2010-10-19 05:44:32 PDT
Comment on attachment 71009 [details]
Proposed patch

Clearing flags on attachment: 71009

Committed r70049: <http://trac.webkit.org/changeset/70049>
Comment 3 Andreas Kling 2010-10-19 05:44:43 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2010-10-19 06:31:24 PDT
http://trac.webkit.org/changeset/70049 might have broken Leopard Intel Release (Tests)
The following tests are not passing:
fast/canvas/canvas-getImageData-negative-source.html