Bug 47567 - Wrong ASSERT when select element has size 0
Summary: Wrong ASSERT when select element has size 0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-12 18:44 PDT by Yael
Modified: 2010-10-13 05:28 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.30 KB, patch)
2010-10-12 19:55 PDT, Yael 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2010-10-12 18:44:14 PDT 
When clicking on a select element and then hitting up or down arrow key, an ASSERT is hit in SelectElement::listBoxDefaultEventHandler().
The ASSERT has wrong assumption and should be fixed. 

ASSERT_UNUSED(listItems, endIndex >= 0 && (unsigned) endIndex < listItems.size());
Comment 1 Yael 2010-10-12 19:55:19 PDT 
Created attachment 70579 [details]
Patch

Change the ASSERT so that it can handle size 0.
Comment 2 Andreas Kling 2010-10-13 05:12:19 PDT 
Comment on attachment 70579 [details]
Patch

Nice catch, r=me
Comment 3 WebKit Commit Bot 2010-10-13 05:28:05 PDT 
Comment on attachment 70579 [details]
Patch

Clearing flags on attachment: 70579

Committed r69651: <http://trac.webkit.org/changeset/69651>
Comment 4 WebKit Commit Bot 2010-10-13 05:28:10 PDT 
All reviewed patches have been landed.  Closing bug.