Bug 47552 - Make TestWebKitAPI work on Windows
Summary: Make TestWebKitAPI work on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks:
 
Reported: 2010-10-12 12:19 PDT by Adam Roben (:aroben)
Modified: 2010-10-13 07:00 PDT (History)
2 users (show)

See Also:

Attachments
Make TestWebKitAPI work on Windows (56.26 KB, patch)
2010-10-12 12:34 PDT, Adam Roben (:aroben) 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-10-12 12:19:42 PDT 
We should make TestWebKitAPI work on Windows.
Comment 1 Adam Roben (:aroben) 2010-10-12 12:20:32 PDT 
<rdar://problem/8541708>
Comment 2 Adam Roben (:aroben) 2010-10-12 12:34:33 PDT 
Created attachment 70555 [details]
Make TestWebKitAPI work on Windows
Comment 3 WebKit Review Bot 2010-10-12 12:35:25 PDT 
Attachment 70555 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/TestWebKitAPI/win/PlatformWebViewWin.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/TestWebKitAPI/TestWebKitAPIPrefix.h:41:  Alphabetical sorting problem.  [build/include_order] [4]
WebKitTools/TestWebKitAPI/win/main.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 4 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Adam Roben (:aroben) 2010-10-13 07:00:35 PDT 
Committed r69656: <http://trac.webkit.org/changeset/69656>