RESOLVED FIXED 47552
Make TestWebKitAPI work on Windows 
https://bugs.webkit.org/show_bug.cgi?id=47552
Summary Make TestWebKitAPI work on Windows
Adam Roben (:aroben)
Reported 2010-10-12 12:19:42 PDT
We should make TestWebKitAPI work on Windows.
Attachments
Make TestWebKitAPI work on Windows (56.26 KB, patch)
2010-10-12 12:34 PDT, Adam Roben (:aroben) 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2010-10-12 12:20:32 PDT
<rdar://problem/8541708>
Adam Roben (:aroben)
Comment 2 2010-10-12 12:34:33 PDT
Created attachment 70555 [details] Make TestWebKitAPI work on Windows
WebKit Review Bot
Comment 3 2010-10-12 12:35:25 PDT
Attachment 70555 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKitTools/TestWebKitAPI/win/PlatformWebViewWin.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKitTools/TestWebKitAPI/TestWebKitAPIPrefix.h:41: Alphabetical sorting problem. [build/include_order] [4] WebKitTools/TestWebKitAPI/win/main.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 4 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Roben (:aroben)
Comment 4 2010-10-13 07:00:35 PDT
Committed r69656: <http://trac.webkit.org/changeset/69656>
Note You need to log in before you can comment on or make changes to this bug.