Bug 47469 - [Qt] Put all DRT-created pages in a page group
Summary: [Qt] Put all DRT-created pages in a page group
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-10-10 08:27 PDT by Robert Hogan
Modified: 2010-10-11 11:28 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.36 KB, patch)
2010-10-10 08:29 PDT, Robert Hogan 		no flags Details | Formatted Diff | Diff
Patch (3.81 KB, patch)
2010-10-10 08:48 PDT, Robert Hogan 		no flags Details | Formatted Diff | Diff
Patch (1.68 KB, patch)
2010-10-10 13:32 PDT, Robert Hogan 		no flags Details | Formatted Diff | Diff
Patch (1.62 KB, patch)
2010-10-10 14:04 PDT, Robert Hogan 		kling: review+
robert: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2010-10-10 08:27:10 PDT 
Fixes: http/tests/security/frameNavigation/not-opener.html
Comment 1 Robert Hogan 2010-10-10 08:29:25 PDT 
Created attachment 70405 [details]
Patch
Comment 2 Robert Hogan 2010-10-10 08:48:11 PDT 
Created attachment 70406 [details]
Patch
Comment 3 WebKit Commit Bot 2010-10-10 10:44:53 PDT 
Comment on attachment 70406 [details]
Patch

Clearing flags on attachment: 70406

Committed r69468: <http://trac.webkit.org/changeset/69468>
Comment 4 WebKit Commit Bot 2010-10-10 10:44:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Robert Hogan 2010-10-10 13:32:03 PDT 
Reopening to fix failing test fast/events/popup-blocked-from-fake-user-gesture.html
Comment 6 Robert Hogan 2010-10-10 13:32:57 PDT 
Created attachment 70412 [details]
Patch
Comment 7 Robert Hogan 2010-10-10 14:04:41 PDT 
Created attachment 70413 [details]
Patch
Comment 8 WebKit Commit Bot 2010-10-10 14:05:11 PDT 
Comment on attachment 70412 [details]
Patch

Clearing flags on attachment: 70412

Committed r69473: <http://trac.webkit.org/changeset/69473>
Comment 9 Andreas Kling 2010-10-11 06:35:58 PDT 
Comment on attachment 70413 [details]
Patch

Looks sane.
Comment 10 Robert Hogan 2010-10-11 11:28:56 PDT 
I committed this unreviewed yesterday as it had turned the bot red.