Bug 47459 - Add WebKit2 version of runBeforeUnloadConfirmPanelWithMessage
Summary: Add WebKit2 version of runBeforeUnloadConfirmPanelWithMessage
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2010-10-09 14:47 PDT by Sam Weinig
Modified: 2010-10-09 14:58 PDT (History)
1 user (show)

See Also:

Patch (13.82 KB, patch)
2010-10-09 14:49 PDT, Sam Weinig
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-10-09 14:47:00 PDT
Add WebKit2 version of runBeforeUnloadConfirmPanelWithMessage
Comment 1 Sam Weinig 2010-10-09 14:47:13 PDT
Comment 2 Sam Weinig 2010-10-09 14:49:24 PDT
Created attachment 70376 [details]
Comment 3 WebKit Review Bot 2010-10-09 14:51:12 PDT
Attachment 70376 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKPage.h:161:  Extra space between WKPageRunBeforeUnloadConfirmPanelCallback and runBeforeUnloadConfirmPanel  [whitespace/declaration] [3]
Total errors found: 1 in 12 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 mitz 2010-10-09 14:55:13 PDT
Comment on attachment 70376 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=70376&action=review

> WebKitTools/MiniBrowser/mac/BrowserWindowController.m:505
> +    NSAlert* alert = [[NSAlert alloc] init];

Misplaced space.
Comment 5 Sam Weinig 2010-10-09 14:58:30 PDT
Landed in r69460.