RESOLVED FIXED 47459
Add WebKit2 version of runBeforeUnloadConfirmPanelWithMessage 
https://bugs.webkit.org/show_bug.cgi?id=47459
Summary Add WebKit2 version of runBeforeUnloadConfirmPanelWithMessage
Sam Weinig
Reported 2010-10-09 14:47:00 PDT
Add WebKit2 version of runBeforeUnloadConfirmPanelWithMessage
Attachments
Patch (13.82 KB, patch)
2010-10-09 14:49 PDT, Sam Weinig 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-10-09 14:47:13 PDT
<rdar://problem/8447690>
Sam Weinig
Comment 2 2010-10-09 14:49:24 PDT
Created attachment 70376 [details] Patch
WebKit Review Bot
Comment 3 2010-10-09 14:51:12 PDT
Attachment 70376 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/UIProcess/API/C/WKPage.h:161: Extra space between WKPageRunBeforeUnloadConfirmPanelCallback and runBeforeUnloadConfirmPanel [whitespace/declaration] [3] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 4 2010-10-09 14:55:13 PDT
Comment on attachment 70376 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70376&action=review > WebKitTools/MiniBrowser/mac/BrowserWindowController.m:505 > + NSAlert* alert = [[NSAlert alloc] init]; Misplaced space.
Sam Weinig
Comment 5 2010-10-09 14:58:30 PDT
Landed in r69460.
Note You need to log in before you can comment on or make changes to this bug.