Bug 47398 – [GTK] Port GTK+ theming code to GTK+ 3.x APIs

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Xan Lopez]

SSIA.

[Xan Lopez]

Created attachment 70206 [details]
gtk3drawing.diff

[WebKit Review Bot]

Attachment 70206 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
Last 3072 characters of output:
amed. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/gtk3drawing.c:1186:  focus_width is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/gtk3drawing.c:1186:  focus_pad is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/gtk3drawing.c:1186:  separator_width is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/gtk3drawing.c:1187:  arrow_req is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/gtk3drawing.c:1188:  Declaration has space between * and variable name in GtkStyle* style  [whitespace/declaration] [3]
WebCore/platform/gtk/gtk3drawing.c:1205:  More than one command on the same line  [whitespace/newline] [4]
WebCore/platform/gtk/gtk3drawing.c:1268:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/gtk/gtk3drawing.c:1268:  Declaration has space between * and variable name in GtkWidget* widget  [whitespace/declaration] [3]
WebCore/platform/gtk/gtk3drawing.c:1270:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/gtk/gtk3drawing.c:1271:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/gtk/gtk3drawing.c:1273:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/gtk/gtk3drawing.c:1273:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/platform/gtk/gtk3drawing.c:1278:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/gtk/gtk3drawing.c:1286:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/platform/gtk/gtk3drawing.c:1303:  Declaration has space between * and variable name in GdkRectangle* rect  [whitespace/declaration] [3]
WebCore/platform/gtk/gtk3drawing.c:1377:  Declaration has space between * and variable name in GtkWidget* moz_gtk_get_scrollbar_widget  [whitespace/declaration] [3]
WebCore/platform/gtk/gtk3drawing.c:1377:  moz_gtk_get_scrollbar_widget is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/gtk3drawing.c:1397:  moz_gtk_destroy_theme_parts_widgets is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/gtk3drawing.c:1408:  Declaration has space between * and variable name in GtkWidget* moz_gtk_get_progress_widget  [whitespace/declaration] [3]
WebCore/platform/gtk/gtk3drawing.c:1408:  moz_gtk_get_progress_widget is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WARNING: File exempt from style guide. Skipping: "WebCore/platform/gtk/gtk2drawing.c"
Total errors found: 181 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Xan Lopez]

Comment on attachment 70206 [details]
gtk3drawing.diff

r=me

[WebKit Commit Bot]

Comment on attachment 70206 [details]
gtk3drawing.diff

Clearing flags on attachment: 70206

Committed r69381: <http://trac.webkit.org/changeset/69381>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Martin Robinson]

We should also add gtk3drawing.c to the list of files exempt from check-webkit-style's clutches.