Bug 46995 - Make direction propagate up to the viewport from the root element.
Summary: Make direction propagate up to the viewport from the root element.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-01 10:25 PDT by Dave Hyatt
Modified: 2010-10-03 10:50 PDT (History)
0 users

See Also:


Attachments
Patch (21.38 KB, patch)
2010-10-01 10:27 PDT, Dave Hyatt
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-10-01 10:25:10 PDT
Make direction propagate up to the viewport from the root element.
Comment 1 Dave Hyatt 2010-10-01 10:27:23 PDT
Created attachment 69483 [details]
Patch
Comment 2 Dave Hyatt 2010-10-01 10:44:16 PDT
Fixed in r68897.
Comment 3 Darin Adler 2010-10-03 10:50:46 PDT
Comment on attachment 69483 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69483&action=review

> WebCore/css/CSSStyleSelector.cpp:1112
> +        // viewport's direction abd block-flow.

Typo: "abd".

> WebCore/rendering/RenderBox.cpp:305
> +        // FIXME: WinIE seems to propagate from the <body> as well.  We may want to consider doing that at some point.

We have been using one space after periods, not two.