Bug 46842 - Add removeRecursively to WebKit WebFileSystem API
Summary: Add removeRecursively to WebKit WebFileSystem API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 42903
  Show dependency tree / graph
 
Reported: 2010-09-29 14:59 PDT by Kinuko Yasuda
Modified: 2010-09-30 13:39 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.12 KB, patch)
2010-09-29 15:01 PDT, Kinuko Yasuda 		dumi: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kinuko Yasuda 2010-09-29 14:59:52 PDT 
For the recent addition of FileSystem API.  An additional flag for existing remove() or a new method is needed.
http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#the-directoryentry-interface
http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#widl-DirectoryEntry-removeRecursively

interface DirectoryEntry : Entry {
    void            removeRecursively (VoidCallback successCallback, optional ErrorCallback errorCallback);
};
Comment 1 Kinuko Yasuda 2010-09-29 15:01:45 PDT 
Created attachment 69255 [details]
Patch
Comment 2 Dumitru Daniliuc 2010-09-29 17:22:01 PDT 
Comment on attachment 69255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69255&action=review

r=me.

> WebKit/chromium/public/WebFileSystem.h:69
> +    virtual void removeRecursively(const WebString& path, WebFileSystemCallbacks*) { WEBKIT_ASSERT_NOT_REACHED(); }

const WebString& path: might have to remove the name of the argument for now, or some compilers might complain that it's not used.
Comment 3 Kinuko Yasuda 2010-09-29 20:02:07 PDT 
Committed r68741: <http://trac.webkit.org/changeset/68741>