Bug 46694 - commit-queue should reject patches that fail to land
Summary: commit-queue should reject patches that fail to land
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-27 20:52 PDT by Adam Barth
Modified: 2010-09-27 21:45 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.23 KB, patch)
2010-09-27 20:53 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-09-27 20:52:41 PDT 
commit-queue should reject patches that fail to land
Comment 1 Adam Barth 2010-09-27 20:53:47 PDT 
Created attachment 69015 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-09-27 21:28:31 PDT 
Comment on attachment 69015 [details]
Patch

This is really subtle.  This feels like a design error.
Comment 3 WebKit Commit Bot 2010-09-27 21:45:36 PDT 
Comment on attachment 69015 [details]
Patch

Clearing flags on attachment: 69015

Committed r68484: <http://trac.webkit.org/changeset/68484>
Comment 4 WebKit Commit Bot 2010-09-27 21:45:41 PDT 
All reviewed patches have been landed.  Closing bug.