Bug 46598 - [GTK][DRT] Implement LayoutTestController::nodesFromRect
Summary: [GTK][DRT] Implement LayoutTestController::nodesFromRect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-26 18:41 PDT by Antonio Gomes
Modified: 2010-11-11 22:21 PST (History)
5 users (show)

See Also:


Attachments
Proposed patch1 (5.45 KB, patch)
2010-11-11 18:15 PST, Joone Hur
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2010-09-26 18:41:30 PDT
fast/dom/nodesFromRect-based.html was skipped by bug 46492.

Needs to implement LayoutTestController::nodesFromRect so unskip. Mac has its implementation from bug 46480.
Comment 1 Joone Hur 2010-11-11 18:15:16 PST
Created attachment 73689 [details]
Proposed patch1

I added nodesFromRect in DRT.
Comment 2 Antonio Gomes 2010-11-11 21:03:42 PST
Why does not this unskip the other nodesFromRect test?
Comment 3 WebKit Commit Bot 2010-11-11 22:21:04 PST
Comment on attachment 73689 [details]
Proposed patch1

Clearing flags on attachment: 73689

Committed r71888: <http://trac.webkit.org/changeset/71888>
Comment 4 WebKit Commit Bot 2010-11-11 22:21:10 PST
All reviewed patches have been landed.  Closing bug.