RESOLVED FIXED 46364
Add synchronous loading for network resources to ResourceHandleWin 
https://bugs.webkit.org/show_bug.cgi?id=46364
Summary Add synchronous loading for network resources to ResourceHandleWin
Patrick R. Gansterer
Reported 2010-09-23 09:49:31 PDT
see patch
Attachments
Patch (3.91 KB, patch)
2010-09-23 09:54 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-09-23 09:54:47 PDT
Created attachment 68534 [details] Patch
WebKit Review Bot
Comment 2 2010-09-23 09:57:24 PDT
Attachment 68534 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/network/win/ResourceHandleWin.cpp:503: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Roben (:aroben)
Comment 3 2010-09-23 10:43:02 PDT
Comment on attachment 68534 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68534&action=review > WebCore/platform/network/win/ResourceHandleWin.cpp:504 > + if (d->m_loadSynchronously) > + while (onRequestComplete()) { > + // Loop until finished. > + } > + I would have expected onRequestComplete to return false when the request is not complete, and true when it is complete.
WebKit Commit Bot
Comment 4 2010-09-23 11:08:44 PDT
Comment on attachment 68534 [details] Patch Clearing flags on attachment: 68534 Committed r68167: <http://trac.webkit.org/changeset/68167>
WebKit Commit Bot
Comment 5 2010-09-23 11:08:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.