Bug 46364 - Add synchronous loading for network resources to ResourceHandleWin
Summary: Add synchronous loading for network resources to ResourceHandleWin
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Patrick R. Gansterer
Depends on:
Blocks: 43712
  Show dependency treegraph
Reported: 2010-09-23 09:49 PDT by Patrick R. Gansterer
Modified: 2010-09-23 13:17 PDT (History)
5 users (show)

See Also:

Patch (3.91 KB, patch)
2010-09-23 09:54 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-09-23 09:49:31 PDT
see patch
Comment 1 Patrick R. Gansterer 2010-09-23 09:54:47 PDT
Created attachment 68534 [details]
Comment 2 WebKit Review Bot 2010-09-23 09:57:24 PDT
Attachment 68534 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/network/win/ResourceHandleWin.cpp:503:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Roben (:aroben) 2010-09-23 10:43:02 PDT
Comment on attachment 68534 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=68534&action=review

> WebCore/platform/network/win/ResourceHandleWin.cpp:504
> +    if (d->m_loadSynchronously)
> +        while (onRequestComplete()) {
> +            // Loop until finished.
> +        }
> +

I would have expected onRequestComplete to return false when the request is not complete, and true when it is complete.
Comment 4 WebKit Commit Bot 2010-09-23 11:08:44 PDT
Comment on attachment 68534 [details]

Clearing flags on attachment: 68534

Committed r68167: <http://trac.webkit.org/changeset/68167>
Comment 5 WebKit Commit Bot 2010-09-23 11:08:48 PDT
All reviewed patches have been landed.  Closing bug.