Bug 46321 - [BREWMP] Enable touch events
Summary: [BREWMP] Enable touch events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 33564
  Show dependency tree / graph
 
Reported: 2010-09-22 16:57 PDT by Kwang Yul Seo
Modified: 2010-09-22 22:15 PDT (History)
2 users (show)

See Also:

Attachments
Patch (7.09 KB, patch)
2010-09-22 17:00 PDT, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-09-22 16:57:23 PDT 
Enable TOUCH_EVENTS by porting PlatformTouchEvent and PlatformTouchPoint. Brew MP does not support multi touch, so enable only single touch for now. 

NOTE: In Brew MP 1.1.0.xxx, there are multi touch events: EVT_POINTER_MT_DOWN, EVT_POINTER_MT_MOVE and EVT_POINTER_MT_UP. Unfortunately, this version is not yet available to the public.
Comment 1 Kwang Yul Seo 2010-09-22 17:00:08 PDT 
Created attachment 68473 [details]
Patch
Comment 2 Adam Barth 2010-09-22 20:47:58 PDT 
Comment on attachment 68473 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68473&action=review

> WebCore/platform/brew/PlatformTouchPointBrew.cpp:37
> +    , m_pos(windowPos) { }

These braces should be on separate lines.
Comment 3 WebKit Commit Bot 2010-09-22 22:15:45 PDT 
Comment on attachment 68473 [details]
Patch

Clearing flags on attachment: 68473

Committed r68123: <http://trac.webkit.org/changeset/68123>
Comment 4 WebKit Commit Bot 2010-09-22 22:15:49 PDT 
All reviewed patches have been landed.  Closing bug.