RESOLVED FIXED 46071
Move reviewtool to action=review 
https://bugs.webkit.org/show_bug.cgi?id=46071
Summary Move reviewtool to action=review
Adam Barth
Reported 2010-09-19 20:31:05 PDT
Move reviewtool to action=review
Attachments
Patch (1.55 KB, patch)
2010-09-19 20:32 PDT, Adam Barth 		eric: review+
abarth: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-09-19 20:32:33 PDT
Created attachment 68048 [details] Patch
Eric Seidel (no email)
Comment 2 2010-09-19 21:24:56 PDT
Comment on attachment 68048 [details] Patch LGTM.
Adam Barth
Comment 3 2010-09-19 21:27:03 PDT
Committed r67835: <http://trac.webkit.org/changeset/67835>
Adam Barth
Comment 4 2010-09-19 21:45:48 PDT
Comment on attachment 68048 [details] Patch Rejecting patch 68048 from commit-queue. Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Parsed 3 diffs from patch file(s). patching file BugsSite/ChangeLog Hunk #1 succeeded at 1 with fuzz 1. patching file BugsSite/attachment.cgi Hunk #1 FAILED at 129. 1 out of 1 hunk FAILED -- saving rejects to file BugsSite/attachment.cgi.rej patching file BugsSite/code-review.js Hunk #1 FAILED at 31. 1 out of 1 hunk FAILED -- saving rejects to file BugsSite/code-review.js.rej Full output: http://queues.webkit.org/results/4073070
Note You need to log in before you can comment on or make changes to this bug.